Alona Kaplan has posted comments on this change. Change subject: webadmin: Accept vlan devices identified by any name ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/27154/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java: Line 120: } Line 121: VdsNetworkInterface vlanBridge = networkToAttach.attach(targetNic, true); Line 122: if (vlanBridge != null) { Line 123: Iterator<VdsNetworkInterface> i = allNics.iterator(); Line 124: // If a vlan device with the same name as the new one already exists- remove it > Please update the comment to reflect what's happening now. Done Line 125: while (i.hasNext()) { Line 126: VdsNetworkInterface nic = i.next(); Line 127: if (vlanBridge.getVlanId().equals(nic.getVlanId())) { Line 128: vlanBridge.setName(nic.getName()); -- To view, visit http://gerrit.ovirt.org/27154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic871fe32377e1b972315aa9c21d9e5cfabd03a03 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
