Eli Mesika has posted comments on this change. Change subject: core: Add FenceKdumpMessage entity ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27200/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/FenceKdumpMessageDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/FenceKdumpMessageDaoDbFacadeImpl.java: Line 48: boolean alive = false; Line 49: FenceKdumpMessage msg = getMostRecent(HEARTBEAT_RECORD); Line 50: if (msg != null) { Line 51: int timeout = Config.<Integer> getValue(ConfigValues.FenceKdumpListenerAliveTimeout) * 1000; Line 52: alive = msg.getReceived().getTime() + timeout > System.currentTimeMillis(); > Not sure I'd put this logic in here. Oved, Seems Ok with me , its like a computed column and I think we are using that in other places as well (I am sure that there are few in the VM DAO) Line 53: } Line 54: return alive; Line 55: } -- To view, visit http://gerrit.ovirt.org/27200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58696ddefa8602b1daa5f55ab4dc11bdc565e265 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
