Lior Vernia has posted comments on this change. Change subject: webadmin: instance types: added support for NIC editing in instance type dialog ......................................................................
Patch Set 31: Clearly I haven't reviewed this in detail, but it might be possible to make this change smaller. What's essentially different between the InstanceType and Vm interface managers? Just the identity of the VdcActionTypes they invoke? If so, then the only difference between them could be three/four members, and no logic difference. Which arguably obviates the need for inheritance at all (these could be arguments passed to a constructor). -- To view, visit http://gerrit.ovirt.org/24562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65346da29c16629f0fa1f17a37218334e5e06c2f Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
