Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: new look and feel based on PatternFly ......................................................................
Patch Set 46: (3 comments) http://gerrit.ovirt.org/#/c/24594/46/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java: Line 37: Line 38: private EntityModelCellTable<ListModel> statisticsTable; Line 39: private EntityModelCellTable<ListModel> guestAgentDataTable; Line 40: Line 41: private final static int TAB_BAR_HEIGHT = 24; > Consider moving this into the TabLayoutPanel class? TabLayoutPanel is a GWT class, but I moved it to CommonApplicationTemplates. Line 42: Line 43: public VmInterfaceInfoPanel(VmInterfaceListModel vmInterfaceListModel, Line 44: CommonApplicationConstants constants, Line 45: CommonApplicationMessages messages, http://gerrit.ovirt.org/#/c/24594/46/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java: Line 40: private EntityModelCellTable<ListModel> disksTable; Line 41: private EntityModelCellTable<ListModel> nicsTable; Line 42: private EntityModelCellTable<ListModel> appsTable; Line 43: Line 44: private final static int TAB_BAR_HEIGHT = 24; > Consider moving this into the TabLayoutPanel class? TabLayoutPanel is a GWT class, but I moved it to CommonApplicationTemplates. Line 45: Line 46: public VmSnapshotInfoPanel(CommonApplicationConstants constants, Line 47: CommonApplicationMessages messages, Line 48: CommonApplicationTemplates templates) { http://gerrit.ovirt.org/#/c/24594/46/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java: Line 137: protected final ApplicationConstants constants; Line 138: Line 139: protected final ApplicationResources resources; Line 140: Line 141: private final static int TAB_BAR_HEIGHT = 24; > Consider moving this into the TabLayoutPanel class? TabLayoutPanel is a GWT class, but I moved it to CommonApplicationTemplates. Line 142: Line 143: @Inject Line 144: public ImportVmPopupView(EventBus eventBus, Line 145: ApplicationResources resources, -- To view, visit http://gerrit.ovirt.org/24594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I806f2d163d80edb632c4e87524c327066cf3377a Gerrit-PatchSet: 46 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
