Sandro Bonazzola has posted comments on this change. Change subject: Removing useless info line on specific exception ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27413/6/src/__main__.py File src/__main__.py: Line 1438: except KeyboardInterrupt, k: Line 1439: print _("Exiting on user cancel.") Line 1440: except NEISODomain, e: Line 1441: logging.error("%s" % e) Line 1442: sys.exit(ExitCodes.LIST_ISO_ERR) maybe better UPLOAD_ERR Line 1443: except Exception, e: Line 1444: # FIXME: add better exceptions handling Line 1445: logging.error("%s" % e) Line 1446: logging.info(_("Use the -h option to see usage.")) -- To view, visit http://gerrit.ovirt.org/27413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4ff43555cb8105e27a83ef8dff5b7df42038ae1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
