Livnat Peer has posted comments on this change. Change subject: core: Add test for SetupNetworksVDSCommandTest ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) the only comment is to remove the usage of spy. .................................................... File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java Line 88: No need for spy as you overload the methods you wanted. -- To view, visit http://gerrit.ovirt.org/5085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4943ca39ca679b74147187f002c6a5b3ab97019 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
