Livnat Peer has posted comments on this change. Change subject: core: Code cleanup SetupNetworksVDSCommand part 1 ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java Line 28: networks should be the returned parameter. I think that updating input parameter is a bad practice. This comment is relevant to all the methods you added and thier name should change accordingly. -- To view, visit http://gerrit.ovirt.org/5086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ac56a3c68dc7ecc7fa6f3449c0b7990ce3e5350 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
