Juan Hernandez has posted comments on this change. Change subject: core: Improve classpath building ......................................................................
Patch Set 1: (3 inline comments) .................................................... File packaging/fedora/engine-java.py Line 33: "commons-codec": "/usr/share/java/commons-codec-eap6/commons-codec.jar", The problem that I am trying to resolve with this is that in RHEL the commons-codec jar file is provided by two packages: the package jakarta-commons-codec provides version 1.3 in /usr/share/java/commons-codec.jar and the EAP package provides version 1.4 in /usr/share/java-signed/commons-codec-eap6/commons-codec.jar. Our code uses methods that only available in version 1.4, so that is the reason for this mapping. In Fedora, for example, the version in /usr/share/java/commons-codec is 1.4. I didn't quite understand what you mean by "partition". Can you elaborate? Line 168: def resolveExactJar(name, path): We need to resolve directories as well, as some of our tools put directories in their classpath (engine-manage-domains puts . and $CONF_DIR, for example). That will be included in the next patch set. Line 276: I will remove it in next patch set. -- To view, visit http://gerrit.ovirt.org/5129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eed7495f8d380656ef413596d7848618e395c96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
