Federico Simoncelli has posted comments on this change. Change subject: core: add the domain detaching state ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/23556/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java: Line 67: getCompensationContext().snapshotEntity(mapToRemove); Line 68: DbFacade.getInstance() Line 69: .getStoragePoolIsoMapDao() Line 70: .remove(new StoragePoolIsoMapId(mapToRemove.getstorage_id(), Line 71: mapToRemove.getstorage_pool_id())); > Please see Liron's comment on patchset 5 - either fix or explain why it's There was a mismatch with the commit message, I fixed that. Line 72: getCompensationContext().stateChanged(); Line 73: return null; Line 74: } Line 75: }); -- To view, visit http://gerrit.ovirt.org/23556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5732ef00a67ef1381ee0b6f29d08ab39cf63a1bf Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
