Daniel Erez has posted comments on this change. Change subject: webadmin: LOCALFS storage path regex validation. ......................................................................
Patch Set 2: (2 inline comments) See inline comments - other than that looks good. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java Line 152: } Why do we need this method? The path Regex is already encapsulated in LocalfsLinuxMountPointValidation class. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LocalfsLinuxMountPointValidation.java Line 13: return "/(.*?/|.*?\\\\)?([^\\./|^\\.\\\\]+)(?:\\.([^\\\\]*)|)"; //$NON-NLS-1$ Do we have some references for the Regex validity? Unit test might be helpful here - but we don't use JUnit tests in the WebAdmin... -- To view, visit http://gerrit.ovirt.org/4857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89a768957974b67754f5a3b78ec8f773e25adc7b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
