Alona Kaplan has posted comments on this change. Change subject: webadmin: Disable clusters incompatible with external networks ......................................................................
Patch Set 2: Code-Review+2 (1 comment) Please fix the comment before merging. http://gerrit.ovirt.org/#/c/26842/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java: Line 114: } Line 115: Line 116: Iterable<NetworkClusterModel> networkClusters = getNetworkClusterList().getItems(); Line 117: if (networkClusters != null) { Line 118: for (NetworkClusterModel networkCluster : getNetworkClusterList().getItems()) { Please use networkClusters instead of getNetworkClusterList().getItems() Line 119: if (!(Boolean) AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.SupportCustomDeviceProperties, Line 120: networkCluster.getEntity().getcompatibility_version().getValue())) { Line 121: networkCluster.setIsChangable(!externalNetwork); Line 122: networkCluster.setAttached(!externalNetwork); -- To view, visit http://gerrit.ovirt.org/26842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida15ca4b63e894ab28f456fdd7e263405d6c679b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
