Alona Kaplan has posted comments on this change. Change subject: webadmin: Allow default profile to turn into ghost entry ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26885/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java: Line 116: public void onValueChange(ValueChangeEvent<String> event) { Line 117: ValueChangeEvent.fire(VnicProfileWidget.this, model); Line 118: } Line 119: }); Line 120: model.getName().getEntityChangedEvent().addListener(new IEventListener() { I don't really understand why do you need this listener. Why should the model fire value change event on the widget? The value is changed on the widget side and the model listens to valueChanged event on the widget. So why should the model fire the event back to the widget? Line 121: @Override Line 122: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 123: ValueChangeEvent.fire(VnicProfileWidget.this, model); Line 124: } -- To view, visit http://gerrit.ovirt.org/26885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0330a07a4af5b911aaa5c3214d56ae381771c0cc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
