Moti Asayag has posted comments on this change. Change subject: engine,webadmin: Encapsulate network properties logic in util ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/27577/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 271: @Override Line 272: protected String getPreDefinedProperties() { Line 273: return Config.<String> getValue(ConfigValues.PreDefinedNetworkCustomProperties, version); Line 274: } Line 275: }; please add a space line Line 276: for (VdsNetworkInterface iface : params.getInterfaces()) { Line 277: if (iface.hasCustomProperties()) { Line 278: String networkName = iface.getNetworkName(); Line 279: if (StringUtils.isEmpty(networkName)) { http://gerrit.ovirt.org/#/c/27577/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/NetworkCustomPropertiesUtils.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/NetworkCustomPropertiesUtils.java: Line 6: import java.util.Map; Line 7: Line 8: import org.ovirt.engine.core.common.businessentities.network.Network; Line 9: Line 10: public abstract class NetworkCustomPropertiesUtils { NetworkCustomPropertiesValidator will describe its nature better, unless you'd like to move validateProperties() to backend implementation. Line 11: Line 12: private static String BRIDGE_OPTS = "bridge_opts"; Line 13: Line 14: private CustomPropertiesUtils utils; Line 12: private static String BRIDGE_OPTS = "bridge_opts"; Line 13: Line 14: private CustomPropertiesUtils utils; Line 15: private Map<String, String> validProperties; Line 16: private Map<String, String> validPropertiesNonVm; s /validPropertiesNonVm/nonVmNetworkValidProperties ? Line 17: Line 18: public NetworkCustomPropertiesUtils() { Line 19: utils = SimpleCustomPropertiesUtil.getInstance(); Line 20: validProperties = new HashMap<String, String>(); -- To view, visit http://gerrit.ovirt.org/27577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib46fffc434a647cc2c603631c0af920ca41ad2f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
