Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Stomp changes in vdsbroker ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/26783/5/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java File backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java: Line 106: ? garble(m) Line 107: : takesShort(m) Line 108: ? Short.valueOf((short) rand(100)) Line 109: : takesInteger(m) Line 110: ? Integer.valueOf(rand(2)) > I use enum for protocol detection which maps ints to enums in range between Juan - thoughts about that? Line 111: : takesLong(m) Line 112: ? Long.valueOf(rand(1000000000)) Line 113: : takesBoolean(m) Line 114: ? Boolean.valueOf(Math.random() < 0.5D) http://gerrit.ovirt.org/#/c/26783/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java: Line 178: Line 179: @UiField Line 180: @Path(value = "protocol.entity") Line 181: @WithElementId("protocol") Line 182: EntityModelCheckBoxEditor protocolEditor; > You are correct but it is a plan for the future. For 3.5 we are going to "s Sure. Line 183: Line 184: @UiField(provided = true) Line 185: @Path(value = "isPm.entity") Line 186: @WithElementId("isPm") -- To view, visit http://gerrit.ovirt.org/26783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If78de6620ba6891543531ac8ddd633b67828a89c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
