Alexander Wels has posted comments on this change. Change subject: webadmin: reports sso token ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/27542/2//COMMIT_MSG Commit Message: Line 8: Line 9: - Implemented ssoToken based on header value returned on Line 10: login instead of cookie which is no longer readable. This Line 11: token is now passed to the reports application instead of Line 12: the cookie value. > perhaps also write that it is based on the session id. It happens to be based on the session id right now, but it could be any token, there is no requirement that it is the sesison id. That is why I didn't mention it. Line 13: Line 14: Change-Id: Ib906a1cca87712fb4e31c68c5e8c70151976ce0f Line 9: - Implemented ssoToken based on header value returned on Line 10: login instead of cookie which is no longer readable. This Line 11: token is now passed to the reports application instead of Line 12: the cookie value. Line 13: > In addition, there is a bug on that. I moved it to post. Done Line 14: Change-Id: Ib906a1cca87712fb4e31c68c5e8c70151976ce0f http://gerrit.ovirt.org/#/c/27542/2/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java: Line 30: */ Line 31: @SuppressWarnings({ "unchecked", "rawtypes" }) Line 32: public class GWTRPCCommunicationProvider implements CommunicationProvider { Line 33: Line 34: private static final String SSO_TOKEN_HEADER = "X-SSO-TOKEN"; //$NON-NLS-1$ > X-OVIRT-SSO-TOKEN? Done Line 35: Line 36: /** Line 37: * GWT RPC service. Line 38: */ -- To view, visit http://gerrit.ovirt.org/27542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib906a1cca87712fb4e31c68c5e8c70151976ce0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
