Alon Bar-Lev has posted comments on this change. Change subject: aaa: Remove dependency at builtin on Common config ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27607/2/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java: Line 47: Line 48: private void doInit(ExtMap inputMap, ExtMap outputMap) { Line 49: context = inputMap.<ExtMap> get(Base.InvokeKeys.CONTEXT); Line 50: configuration = context.<Properties> get(Base.ContextKeys.CONFIGURATION); Line 51: Config.setConfiguration((Properties) configuration.get("config")); please make sure you have defaults for all, so that you can work without variables specified. Line 52: broker = LdapFactory.getInstance(getAuthzName()); Line 53: context.<List<String>> get( Line 54: Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS Line 55: ).add("config.authn.user.password"); -- To view, visit http://gerrit.ovirt.org/27607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1384a99f73ab605b61bce8dcdfd63e222b0001fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
