Tomas Jelinek has posted comments on this change.

Change subject: frontend: Control virtio rng device
......................................................................


Patch Set 25:

(1 comment)

http://gerrit.ovirt.org/#/c/18497/25/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java:

Line 486:                         
param.setConsoleEnabled(model.getIsConsoleDeviceEnabled().getEntity());
Line 487:                         
param.setVirtioScsiEnabled(model.getIsVirtioScsiEnabled().getEntity());
Line 488: 
Line 489:                         
param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity());
Line 490:                         
param.setRngDevice(model.getIsRngEnabled().getEntity() ? 
model.generateRngDevice() : null);
you miss the param.setUpdateRngDevice(true);
Line 491: 
Line 492:                         
param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity());
Line 493:                         if (model.getQuota().getSelectedItem() != 
null) {
Line 494:                             
vm.setQuotaId(model.getQuota().getSelectedItem().getId());


-- 
To view, visit http://gerrit.ovirt.org/18497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffbc48062f25d90795bc360362f42cd1042fb888
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to