Dima Kuznetsov has posted comments on this change. Change subject: webadmin: Move CPU info to HW info tab ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/27255/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java: Line 944: } Line 945: } Line 946: Line 947: if (vds.getVdsGroupCompatibilityVersion() != null Line 948: && Version.v3_2.compareTo(vds.getVdsGroupCompatibilityVersion()) > 0) { > Do we have a configuration value we can use instead? Any idea where I might find it? Line 949: setLogicalCores(vds.getCpuCores()); Line 950: } else { Line 951: setLogicalCores(vds.getCpuThreads()); Line 952: } http://gerrit.ovirt.org/#/c/27255/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java: Line 250: setCpuType(vds.getCpuName() != null ? vds.getCpuName().getCpuName() : null); Line 251: setCpuModel(vds.getCpuModel()); Line 252: setNumberOfSockets(vds.getCpuSockets()); Line 253: setCoresPerSocket((vds.getCpuCores() != null && vds.getCpuSockets() != null) Line 254: ? vds.getCpuCores() / vds.getCpuSockets() : null); > Could 'vds.getCpuSockets()' be '0' by any reason? Done Line 255: Line 256: if (vds.getVdsGroupCompatibilityVersion() != null Line 257: && Version.v3_2.compareTo(vds.getVdsGroupCompatibilityVersion()) > 0) { Line 258: // Members of pre-3.2 clusters don't support SMT; here we act like a 3.1 engine Line 259: setThreadsPerCore(constants.unsupported()); Line 260: } else if (vds.getCpuThreads() == null || vds.getCpuCores() == null) { Line 261: setThreadsPerCore(constants.unknown()); Line 262: } else { Line 263: Integer threads = vds.getCpuThreads() / vds.getCpuCores(); > worth verifying vds.getCpuCores() is not 0? Done Line 264: setThreadsPerCore(messages Line 265: .commonMessageWithBrackets(threads.toString(), Line 266: threads > 1 ? constants.smtEnabled() Line 267: : constants.smtDisabled())); Line 263: Integer threads = vds.getCpuThreads() / vds.getCpuCores(); Line 264: setThreadsPerCore(messages Line 265: .commonMessageWithBrackets(threads.toString(), Line 266: threads > 1 ? constants.smtEnabled() Line 267: : constants.smtDisabled())); > formatter Done Line 268: } Line 269: Line 270: /* Go through the list of HBA devices and transfer the necessary info Line 271: to the GWT host hardware model */ -- To view, visit http://gerrit.ovirt.org/27255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e44c8ddb9b144cc322a7ea7772cf99cdf4807fc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
