Oved Ourfali has posted comments on this change. Change subject: core: Support decreasing dc compatbility version ......................................................................
Patch Set 8: (1 comment) Another comment: we need to update the bug with the details we decided on in the mailing list, as Eli's comment on the bug contains different restrictions. http://gerrit.ovirt.org/#/c/26947/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java: Line 191: // decreasing of compatibility version is not allowed Line 192: else if (getStoragePool().getcompatibility_version().compareTo(_oldStoragePool.getcompatibility_version()) < 0) { Line 193: // Enable to reduce compatibility version if DC has no hosts Line 194: Line 195: if (!getVdsDAO().getAllForStoragePool(getStoragePoolId()).isEmpty()) { > So, should we always allow for DC downgrade? What's the impact of this down DC level enforces support for that on the hosts. So, if you have hosts with older version of VDSM, then you'll need to have a proper DC level as well. If you're not setting the DC level properly upon creation, then you can't use older hosts, so you're pretty much stuck. Line 196: returnValue = false; Line 197: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION); Line 198: } Line 199: if (returnValue) { -- To view, visit http://gerrit.ovirt.org/26947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bb99e4773ee5592483ad055b277641ebc63cae1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
