Sahina Bose has posted comments on this change. Change subject: engine: Wait before clearing gluster tasks ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24712/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java: Line 353: values.put(GlusterConstants.JOB_STATUS, JobExecutionStatus.UNKNOWN.toString()); Line 354: values.put(GlusterConstants.JOB_INFO, " "); Line 355: Line 356: for (Step step: steps) { Line 357: if (TimeUnit.MILLISECONDS.toMinutes(System.currentTimeMillis() - step.getStartTime().getTime()) < 10) { > i find it a strange solution to a problem, but at least make it configurabl Will add a configuration value for this. Since we are executing a distributed command to get the details of the tasks created, depending on which server in the cluster we ask for this info, the task may not be returned...this is because glusterd takes some time to sync details across servers in the cluster. Do you have any alternated suggestions for this problem? Line 358: //This task has been recently created. We will give it 10 mins before clearing it. Line 359: continue; Line 360: } Line 361: step.markStepEnded(JobExecutionStatus.UNKNOWN); -- To view, visit http://gerrit.ovirt.org/24712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a8a4878abb7ef46adedfdb099404884419f89de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
