Yaniv Bronhaim has uploaded a new change for review. Change subject: api: Fix approve API to allow deploy with public key ......................................................................
api: Fix approve API to allow deploy with public key Currently we don't set the authentication method and engine searches for password validation. Approve should always use PK auth (Apperently approve call by API was never tested and failed on "empty password"). Change-Id: I9816d907d45ec7b4ee066fa369ca1150e688084f Signed-off-by: Yaniv Bronhaim <[email protected]> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/22/27622/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java index 1f981d4..fc5d9c6 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java @@ -137,6 +137,10 @@ ApproveVdsParameters params = new ApproveVdsParameters(guid); params = (ApproveVdsParameters) getMapper (Action.class, VdsOperationActionParameters.class).map(action, (VdsOperationActionParameters) params); + + // Approve as default use public key. if password is allowed the api should change to provide authentication + // method and user\password + params.setAuthMethod(VdsOperationActionParameters.AuthenticationMethod.PublicKey); return doAction(VdcActionType.ApproveVds, params, action); -- To view, visit http://gerrit.ovirt.org/27622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9816d907d45ec7b4ee066fa369ca1150e688084f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
