Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: hardening postgresql password
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27615/1/packaging/setup/ovirt_engine_setup/postgres.py
File packaging/setup/ovirt_engine_setup/postgres.py:

Line 466:             )
Line 467: 
Line 468:     def generatePassword(self):
Line 469:         rand = random.SystemRandom()
Line 470:         return ''.join([rand.choice(self._PASSWORD_CHARS) for i in 
range(22)])
> Adding 2 extra chars to _PASSWORD_CHARS would normally be recommended to ma
Thanks Michael
Line 471: 
Line 472:     def applyEnvironment(self):
Line 473:         for k in ('user', 'database', 'port', 'secured', 
'hostValidation'):
Line 474:             self.environment[self._dbenvkeys[k]] = self._defaults[k]


-- 
To view, visit http://gerrit.ovirt.org/27615
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76769e7eb65df35f982b1ef9e36bc81d1f42b79a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Samuel <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to