Shahar Havivi has posted comments on this change. Change subject: core: copy disks from template instead of instance type ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27630/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 809: */ Line 810: private void copyDiskDevicesFromTemplate() { Line 811: Guid templateId = getParameters().getVmStaticData().getVmtGuid(); Line 812: Line 813: List<VmDevice> disks = DbFacade.getInstance().getVmDeviceDao().getVmDeviceByVmIdAndType(templateId, VmDeviceGeneralType.DISK); > wouldnt this return also cd rom? yes, you may want to use that List<VmDevice> vmDevices = DbFacade.getInstance() .getVmDeviceDao() .getVmDeviceByVmIdTypeAndDevice(vm.getId(), VmDeviceGeneralType.DISK, VmDeviceType.DISK.getName()); Line 814: VmDeviceUtils.copyVmDevices( Line 815: templateId, Line 816: getVmId(), Line 817: getVm(), -- To view, visit http://gerrit.ovirt.org/27630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddc4d3da99c0a459c7339639cca15cbb597df18 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
