Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup VdsUpdateRunTimeInfo
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Looks good.
I would like someone else to view this -
One comment -
It's well known that this class has some spaghetti issues.
I would have separated the cleanup of
if (....) {
....
return;
} else {
...
}
which removes the else , to a separate patch.
--
To view, visit http://gerrit.ovirt.org/5203
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief76350281768ceb327b046d526e5450bb3c2bdd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
