Oved Ourfali has posted comments on this change. Change subject: ui: adding discover host integration to AddHost view ......................................................................
Patch Set 2: (1 comment) We will also need to add compute resource selection here. http://gerrit.ovirt.org/#/c/27623/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java: Line 137: return type == ProviderType.OPENSTACK_NETWORK || type == ProviderType.OPENSTACK_IMAGE; Line 138: } Line 139: Line 140: private boolean isTypeRequiresAuthentication() { Line 141: // TODO: rememeber to remove. this to allow using foreman livecd that does not require authentication. Remove the comment. We can put it as non-required by default, for all types. In the future, if someone wants something to require authentication it can be set here. Line 142: //ProviderType type = (ProviderType) getType().getSelectedItem(); Line 143: //return type == ProviderType.FOREMAN; Line 144: return false; Line 145: } -- To view, visit http://gerrit.ovirt.org/27623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0faf667019760326019368f044ee16265d41a620 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
