Martin Mucha has posted comments on this change. Change subject: core: performance improvement ......................................................................
Patch Set 7: (1 comment) added test. http://gerrit.ovirt.org/#/c/25940/7/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java: Line 47: Line 48: return macAddresses; Line 49: } Line 50: Line 51: private static String macAddressToString(long macAddress) { > Please do add the tests in the current patch. Done Line 52: String value = String.format("%012x", macAddress); Line 53: char[] chars = value.toCharArray(); Line 54: Line 55: final StringBuilder stringBuilder = new StringBuilder(); -- To view, visit http://gerrit.ovirt.org/25940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09f87ebd1ea17d09a974ce6ca3e26bd2454a72fc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
