Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: use db creds from answer file
......................................................................
Patch Set 1: Verified+1
Steps to reproduce the bug:
3.3 engine/dwh/reports setup
yum update engine/dwh/reports setup packages to 3.4
engine-setup, exit at end of validation ('Cancel')
engine-setup again, using the answer file generated at previous step
Why this fails?
In 3.3 we keep in dwh's conf file only db/user/password and not host/port,
because they can't be different from engine's, and we use the engine's.
Normally when upgrading, ENABLE is False at this stage (_setup), and we do not
enter it.
When using the answer file, ENABLE is True and so we do enter.
Current fix is somewhat a hack, but I think we can live with it.
A better fix would have been to have an env key that is added to postinstall in
3.4 but not kept in answer file, and check it for this function (and not
ENABLE), probably similarly to what Alon added in http://gerrit.ovirt.org/26463
. Not sure it's worth it, though.
--
To view, visit http://gerrit.ovirt.org/27693
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac431a840c1207313c5a4b6e47eace93d1dd099
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
