Kobi Ianko has posted comments on this change. Change subject: db: aggregate qos and storage qos impl ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/27094/5/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java: Line 35: StorageQos storageQos = new StorageQos(); Line 36: storageQos.setId(qosAId); Line 37: storageQos.setName("qos_a"); Line 38: storageQos.setDescription("You don't understand. There's relationship George, and then there's the George you know. Baudy George, Funny George"); Line 39: storageQos.setStoragePoolId(FixturesTool.STORAGE_POOL_NFS_2); I'm missing the change in FixturesTool, adding STORAGE_POOL_NFS_2 Line 40: storageQos.setMaxThroughput(1000); Line 41: storageQos.setMaxReadThroughput(2000); Line 42: storageQos.setMaxWriteThroughput(500); Line 43: storageQos.setMaxIops(1000); Line 103: * Test getAllForStoragePool Line 104: */ Line 105: @Test Line 106: public void testGetAllStorageQosForStoragePool() { Line 107: assertEquals(2, dao.getAllForStoragePoolId(FixturesTool.STORAGE_POOL_NFS_2).size()); We should consider filtering by type, I'm adding some more qos elements Line 108: } Line 109: -- To view, visit http://gerrit.ovirt.org/27094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d63b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
