Vojtech Szocs has posted comments on this change. Change subject: docker: include jquery from secured link ......................................................................
Patch Set 3: Hi Oved, you might want to consider using: <script src="//code.jquery.com/jquery-latest.js"></script> instead of: <script src="https://code.jquery.com/jquery-latest.js";></script> this should load the remote script using protocol of enclosing web page, avoiding issues like WebAdmin page loaded via HTTPS and script loaded via HTTP which might be treated as insecure content. Note that all links to plugin static resources should be relative, for example in plugin.html: <script src="js/init.js"></script> assuming there is docker-resources/js/init.js file present. -- To view, visit http://gerrit.ovirt.org/27645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06bd1665ab6c3217c101e6b517ea2bd3b397c052 Gerrit-PatchSet: 3 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
