Daniel Erez has posted comments on this change.

Change subject: core: Repair disallow RO in UI
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/27665/5/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
File 
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java:

Line 2236:     @DefaultStringValue("An IDE disk can't be read-only.")
Line 2237:     String cannotEnableIdeInterfaceForReadOnlyDisk();
Line 2238: 
Line 2239:     @DefaultStringValue("A VirtIO-ISCSI directi-LUN disk can't be 
read-only.")
Line 2240:     String cannotEnableVirtIoScsiInterfaceForLunReadOnlyDisk();
Phrasing should be similar to Disks main-tab :)
* "Direct LUN"
Line 2241: 
Line 2242:     @DefaultStringValue("Global Maintenance Enabled")
Line 2243:     String haGlobalMaintenance();
Line 2244: 


-- 
To view, visit http://gerrit.ovirt.org/27665
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to