Alissa Bonas has posted comments on this change. Change subject: engine: Add custom mount options to NFS SD ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27694/1/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java: Line 84: if (nfsVersion != null) { Line 85: entity.setNfsVersion(map(nfsVersion, null)); Line 86: } Line 87: } Line 88: if (storage.isSetMountOptions()) { > Alissa: you are right that there's no verification that the mount options a I don't mind that such a parser will be added in a separate patch, however since in NFS case we already explicitly provide to users a possibility to fill 3 very specific mount options (and as I noted in another comment - this is confusing with the new mount options field), it will be non generic handling anyway to handle validation of those separate fields against the generic mount options new field (new = for NFS). Line 89: entity.setMountOptions(storage.getMountOptions()); Line 90: } Line 91: break; Line 92: case LOCALFS: -- To view, visit http://gerrit.ovirt.org/27694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c7d51f5bf1ffb3491788b9fcda770a55b94cf50 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xavi Francisco <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
