Yevgeny Zaspitsky has posted comments on this change. Change subject: core: Adding the CpuQos entity ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/27662/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java: Line 17: message = "ACTION_TYPE_FAILED_QOS_OUT_OF_RANGE_VALUES") Line 18: private Integer cpuLimit; Line 19: Line 20: @Override Line 21: public int valuesHashCode() { See my comments regarding equals/hashCode/equalValues/valuesHashCode in BaseQos class Line 22: final int prime = 31; Line 23: int result = super.hashCode(); Line 24: result = prime * result + ((cpuLimit == null) ? 0 : cpuLimit.hashCode()); Line 25: return result; Line 25: return result; Line 26: } Line 27: Line 28: @Override Line 29: public boolean equalValues(BaseQos obj) { See my comments regarding equals/hashCode/equalValues/valuesHashCode in BaseQos class Line 30: if (this == obj) Line 31: return true; Line 32: if (getClass() != obj.getClass()) Line 33: return false; Line 40: return true; Line 41: } Line 42: Line 43: @Override Line 44: public String getString() { See my comments regarding toString/getString in BaseQos class Line 45: StringBuilder builder = new StringBuilder(); Line 46: builder.append("CpuQos [cpuLimit="); Line 47: builder.append(cpuLimit); Line 48: builder.append("]"); -- To view, visit http://gerrit.ovirt.org/27662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2134a778d70b3c9ff3e78cc38282a515250b7cf2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
