Greg Padgett has uploaded a new change for review. Change subject: [WIP] core: move AsyncTaskBase variable declarations to top of file ......................................................................
[WIP] core: move AsyncTaskBase variable declarations to top of file Adopt the standard convention by moving variable declarations from above their getters/setters to the top of the file. Change-Id: I558a0b2632fbef59eee410b5da03379810bd54ea Bug-Url: https://bugzilla.redhat.com/1058160 Signed-off-by: Greg Padgett <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java 1 file changed, 9 insertions(+), 15 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/27749/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java index 4909267..1e1ba38 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java @@ -21,15 +21,20 @@ public class AsyncTaskBase implements AsyncTask { CommandCoordinator coco; + private AsyncTaskParameters privateParameters; + private Map<Guid, VdcObjectType> entitiesMap; + private AsyncTaskState privateState = AsyncTaskState.forValue(0); + private AsyncTaskStatus _lastTaskStatus = new AsyncTaskStatus(AsyncTaskStatusEnum.init); + // Indicates time in milliseconds when task status recently changed. + protected long _lastAccessToStatusSinceEnd = System.currentTimeMillis(); + private boolean partiallyCompletedCommandTask = false; + private static final Log log = LogFactory.getLog(AsyncTaskBase.class); + public AsyncTaskBase(CommandCoordinator coco, AsyncTaskParameters parameters) { this.coco = coco; setParameters(parameters); setState(AsyncTaskState.Initializing); } - - private AsyncTaskParameters privateParameters; - - private Map<Guid, VdcObjectType> entitiesMap; public Map<Guid, VdcObjectType> getEntitiesMap() { return entitiesMap; @@ -55,8 +60,6 @@ return getParameters().getStoragePoolID(); } - private AsyncTaskState privateState = AsyncTaskState.forValue(0); - public AsyncTaskState getState() { return privateState; } @@ -71,8 +74,6 @@ && getLastTaskStatus().getStatus() != AsyncTaskStatusEnum.unknown && (getParameters().getEntityInfo() == null ? isTaskOverPrePollingLapse() : true); } - - private AsyncTaskStatus _lastTaskStatus = new AsyncTaskStatus(AsyncTaskStatusEnum.init); @Override public AsyncTaskStatus getLastTaskStatus() { @@ -103,9 +104,6 @@ _lastAccessToStatusSinceEnd = System.currentTimeMillis(); } } - - // Indicates time in milliseconds when task status recently changed. - protected long _lastAccessToStatusSinceEnd = System.currentTimeMillis(); @Override public long getLastAccessToStatusSinceEnd() { @@ -477,10 +475,6 @@ protected void LogTaskCleanFailure() { log.errorFormat("Clearing task '{0}' failed.", getVdsmTaskId()); } - - private static final Log log = LogFactory.getLog(AsyncTaskBase.class); - - private boolean partiallyCompletedCommandTask = false; public boolean isPartiallyCompletedCommandTask() { return partiallyCompletedCommandTask; -- To view, visit http://gerrit.ovirt.org/27749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I558a0b2632fbef59eee410b5da03379810bd54ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
