Alexander Wels has posted comments on this change. Change subject: webadmin: auto select dialog tab ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27781/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java: Line 57: Line 58: public abstract class HostModel extends Model implements HasValidatedTabs Line 59: { Line 60: public enum HostTabNames implements TabName { Line 61: GENERAL_TAB, POWER_MANAGEMENT_TAB, SPM_TAB, CONSOLE_TAB, NETWORK_PROVIDER_TAB Maybe consolidate this enum in an external enum for all the models. There seems to be a lot of overlap. The mapping happens in the view anyway. Line 62: } Line 63: Line 64: public static final int HostNameMaxLength = 255; Line 65: public static final String PmSecureKey = "secure"; //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/27781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9c5ad0cd3ee7f54606958b1fc8abd2bbd972ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
