Yair Zaslavsky has posted comments on this change. Change subject: aaa: Chages to ExtensionsManager ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/27785/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 64: // TODO: remove this later, and rely only on the custom and built in extensions directories configuration Line 65: Line 66: createInternalAAAConfigurations(); Line 67: createKerberosLdapAAAConfigurations(); Line 68: EngineExtensionsManager.getInstance().dump(); > hmmm... just an idea... move all these to the EngineExtensionsManager? so i Done Line 69: AuthenticationProfileRepository.getInstance(); Line 70: DbUserCacheManager.getInstance().init(); Line 71: AsyncTaskManager.getInstance().initAsyncTaskManager(); Line 72: ResourceManager.getInstance().init(); http://gerrit.ovirt.org/#/c/27785/10/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 293: ); Line 294: entry.activated = true; Line 295: dumpConfig(entry.extension); Line 296: setChanged(); Line 297: notifyObservers(); > I think that best to notify observers also when loading, to allow activatin Done Line 298: } Line 299: } Line 300: Line 301: private Extension loadExtension(Properties props) throws Exception { http://gerrit.ovirt.org/#/c/27785/10/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java: Line 8: import org.ovirt.engine.core.extensions.mgr.ExtensionProxy; Line 9: import org.ovirt.engine.core.extensions.mgr.ExtensionsManager; Line 10: import org.ovirt.engine.core.utils.EngineLocalConfig; Line 11: import org.ovirt.engine.core.utils.log.Log; Line 12: import org.ovirt.engine.core.utils.log.LogFactory; > why not use commons logging? just a question... I don't see a real benefit here, as utils is a part of engine. Line 13: Line 14: public class EngineExtensionsManager { Line 15: Line 16: private static final String ENGINE_EXTENSION_ENABLED = "ENGINE_EXTENSION_ENABLED_"; -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
