Yair Zaslavsky has posted comments on this change. Change subject: engine : Support logging of commands parameters ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27780/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1165: } Line 1166: Line 1167: private String getCommandParameters(T params) { Line 1168: final String GET = "get"; Line 1169: StringBuilder buf = new StringBuilder(""); no need for "" , you can use empty CTOR. Line 1170: List<String> methodNames = ReflectionUtils.getMethodNames(params); Line 1171: methodNames.removeAll(ReflectionUtils.getMethodNames(new VdcActionParametersBase())); Line 1172: Line 1173: for (String methodName : methodNames) { -- To view, visit http://gerrit.ovirt.org/27780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfd9423e92f9f9c9a51eca24b20157cc32681018 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
