Roy Golan has posted comments on this change. Change subject: core: VdsManger - rename fields to fit convention ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27378/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 98: @Override Line 99: public void handleSecureSetup() { Line 100: // if ssl is on and no certificate file Line 101: if (Config.<Boolean> getValue(ConfigValues.EncryptHostCommunication) Line 102: && !EngineEncryptionUtils.haveKey()) { > why did you remove this? reversing it. its a part of a future refactor I made Line 103: log.error("Could not find VDC Certificate file."); Line 104: AuditLogableBase logable = new AuditLogableBase(vdsId); Line 105: AuditLogDirector.log(logable, AuditLogType.CERTIFICATE_FILE_NOT_FOUND); Line 106: } -- To view, visit http://gerrit.ovirt.org/27378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90e26c1a2db4d51f5bd13cf39a59593579fa7648 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
