Shirly Radco has posted comments on this change.

Change subject: reports: br18a report - added comments to queries
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27810/1/packaging/ovirt-reports/resources/reports_resources/embedded_reports/Inventory_Dashboard/active_entities_by_os_BR18A_files/active_entities_by_os_BR18A_jrxml.data
File 
packaging/ovirt-reports/resources/reports_resources/embedded_reports/Inventory_Dashboard/active_entities_by_os_BR18A_files/active_entities_by_os_BR18A_jrxml.data:

Line 139:                 THEN v3_5_configuration_history_vms.cluster_id
Line 140:             WHEN '11111111-1111-1111-1111-111111111111'
Line 141:                 THEN v3_5_configuration_history_vms.cluster_id
Line 142:             ELSE CAST ( $P{P_Cluster_ID} AS uuid )
Line 143:         END
> should be indented by one more tab
Done
Line 144:         -- Here we get the latest vms configuration
Line 145:         AND a.history_id IN (
Line 146:             SELECT MAX ( b.history_id )
Line 147:             FROM v3_5_configuration_history_vms AS b


-- 
To view, visit http://gerrit.ovirt.org/27810
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bbb94ff6caa6658d2d4ab3ca666be83de1a307f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <[email protected]>
Gerrit-Reviewer: Shirly Radco <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to