Vojtech Szocs has posted comments on this change. Change subject: Docker plugin - add tag "latest" when tag not specified ......................................................................
Patch Set 4: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/27563/4/docker-plugin/docker-resources/launch-docker-dialog.html File docker-plugin/docker-resources/launch-docker-dialog.html: Line 132: // Setting the image Line 133: // If the user didn't input a tag name, append "latest" Line 134: // to download only the one tagged as latest and avoid downloading all the repository, Line 135: // because docker will run the latest, so no need to download the other images. Line 136: if(image.indexOf(':') < 0) { Minor thing, please use a space between "if" and "(" so that it doesn't appear as function invocation. Line 137: image +=':latest'; Line 138: } Line 139: result += ', "' + image + '"'; Line 140: -- To view, visit http://gerrit.ovirt.org/27563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e875733797e8fcebd557c35e230dcdb6fb5512e Gerrit-PatchSet: 4 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
