Vojtech Szocs has posted comments on this change. Change subject: Make 'create docker VM' button always enabled ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/27666/1/docker-plugin/docker-resources/plugin.html File docker-plugin/docker-resources/plugin.html: Line 110: var init = function() { Line 111: api.addMainTabActionButton('VirtualMachine', 'Create Docker VM', Line 112: { Line 113: isEnabled: function() { Line 114: return true; Having an action button always enabled is the default behavior, as defined in ActionButtonInterface.isEnabled method contract. You can consider removing "isEnabled" function entirely here, relying on the default behavior. Line 115: }, Line 116: onClick: function() { Line 117: api.showDialog('Create Docker VM', 'launch-docker', Line 118: 'plugin/docker/launch-docker-dialog.html', -- To view, visit http://gerrit.ovirt.org/27666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d2b3e6f6d05cfdbaf93f0694dbe6ab13f3aeaf1 Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
