Mike Kolesnik has posted comments on this change. Change subject: core: [rmd] remove VdsSelector ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java Line 234: return null; IMHO returning null here and then checking for it is not nice behaviour. Did you consider using ValidationResult for the job? .................................................... Commit Message Line 7: core: [rmd] remove VdsSelector What is [rmd]? Also from this subject it looks like you're deleting this class entirely.. -- To view, visit http://gerrit.ovirt.org/5248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba063e42ded77b8f7c008cb4878d3c27f440f167 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
