Yaniv Bronhaim has posted comments on this change. Change subject: core: Foreman discovery host integration to ovirt ......................................................................
Patch Set 4: (2 comments) thanks http://gerrit.ovirt.org/#/c/27621/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 93: runHttpMethod(httpClient, httpMethod); Line 94: ForemanDiscoveredHostWrapper fdw = Line 95: objectMapper.readValue(httpMethod.getResponseBody(), ForemanDiscoveredHostWrapper.class); Line 96: return mapDiscoveredHosts(Arrays.asList(fdw.getResults())); Line 97: } catch (JsonParseException e) { > I think here it is the same as doing only going with that, maybe handleException() should do the switch case on type for different reports Line 98: handleException(e); Line 99: } catch (JsonMappingException e) { Line 100: handleException(e); Line 101: } catch (IOException e) { http://gerrit.ovirt.org/#/c/27621/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java: Line 40: public void setLast_report(String last_report) { Line 41: this.last_report = last_report; Line 42: } Line 43: Line 44: private String last_report; > or better: I don't need it, i can call it lastReport here, its just the business entity . will change to java naming conversions -- To view, visit http://gerrit.ovirt.org/27621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c25a544373d8ab4a7123137c8a4697205a8efa8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
