Arik Hadas has posted comments on this change. Change subject: core: Adding import of unregistered VM template ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/27581/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java: Line 156: getVmTemplate().setDiskImageMap(imageMap); Line 157: } Line 158: } Line 159: Line 160: if (retVal && getParameters().isImportAsNewEntity()) { don't we need to block import of unregistered template as new entity (since the images won't be copied) ? Line 161: initImportClonedTemplate(); Line 162: } Line 163: Line 164: if (retVal) { http://gerrit.ovirt.org/#/c/27581/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java: Line 24: @NonTransactiveCommandAttribute(forceCompensation = true) Line 25: public class ImportVmTemplateFromConfigurationCommand<T extends ImportVmTemplateParameters> extends ImportVmTemplateCommand { Line 26: Line 27: private static final Log log = LogFactory.getLog(ImportVmFromConfigurationCommand.class); Line 28: OvfEntityData ovfEntityData; private? Line 29: Line 30: protected ImportVmTemplateFromConfigurationCommand(Guid commandId) { Line 31: super(commandId); Line 32: } Line 61: if (!getStorageDomain().getStorageDomainType().isDataDomain()) { Line 62: addCanDoActionMessage("$domainId " + getParameters().getStorageDomainId()); Line 63: addCanDoActionMessage("$domainType " + getStorageDomain().getStorageDomainType()); Line 64: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_UNSUPPORTED); Line 65: return false; same as in previous patch - can we use failCan... method instead? Line 66: } Line 67: } Line 68: getParameters().setImages(getVmTemplate().getImages()); Line 69: return super.canDoAction(); -- To view, visit http://gerrit.ovirt.org/27581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fc184e687cbeebf4aa732c901f98222d5b11097 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
