Daniel Erez has posted comments on this change. Change subject: core: avoid broken status on snapshot removal ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/27611/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java: Line 202: getParameters().getSnapshotId(), imagesParams.getImageId()); Line 203: getSnapshotDao().update(snapshotWithoutImage); Line 204: } Line 205: else { Line 206: log.errorFormat("Could not delete image {1} from snapshot {2}", > /s/{1}/{0} Done Line 207: getParameters().getSnapshotId(), imagesParams.getImageId()); Line 208: Line 209: DiskImage diskImage = getDiskImageDao().getSnapshotById(imagesParams.getImageId()); Line 210: failedToRemoveDisks.add(diskImage.getDiskAlias()); http://gerrit.ovirt.org/#/c/27611/5/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 51: USER_CREATE_LIVE_SNAPSHOT_FINISHED_FAILURE=Failed to create live snapshot '${SnapshotName}' for VM '${VmName}'. VM restart is recommended. Line 52: USER_REMOVE_SNAPSHOT=Snapshot '${SnapshotName}' deletion for VM '${VmName}' was initiated by ${UserName}. Line 53: USER_REMOVE_SNAPSHOT_FINISHED_SUCCESS=Snapshot '${SnapshotName}' deletion for VM '${VmName}' has been completed. Line 54: USER_REMOVE_SNAPSHOT_FINISHED_FAILURE=Failed to delete snapshot '${SnapshotName}' for VM '${VmName}'. Line 55: USER_REMOVE_SNAPSHOT_FINISHED_FAILURE_PARTIAL_SNAPSHOT=Due to partial snapshot removal, Snapshot '${SnapshotName}' of VM '${VmName}' now contains only the following disks: '${DiskAlias}'. > /s/DiskAlias/DiskAliases Done Line 56: USER_REMOVE_DISK_SNAPSHOT=Disk '${DiskAlias}' from Snapshot(s) '${Snapshots}' of VM '${VmName}' deletion was initiated by ${UserName}. Line 57: USER_FAILED_REMOVE_DISK_SNAPSHOT=Failed to delete Disk '${DiskAlias}' from Snapshot(s) ${Snapshots} of VM ${VmName} (User: ${UserName}). Line 58: USER_REMOVE_DISK_SNAPSHOT_FINISHED_SUCCESS=Disk '${DiskAlias}' from Snapshot(s) '${Snapshots}' of VM '${VmName}' deletion has been completed (User: ${UserName}). Line 59: USER_REMOVE_DISK_SNAPSHOT_FINISHED_FAILURE=Failed to complete deletion of Disk '${DiskAlias}' from snapshot(s) '${Snapshots}' of VM '${VmName}' (User: ${UserName}). -- To view, visit http://gerrit.ovirt.org/27611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a15034185ef30f53fbeaa46440cd92954d39eee Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
