Gilad Chaplik has posted comments on this change.

Change subject: core: Add Audit log for failed to run prestarted VMs
......................................................................


Patch Set 1:

(1 comment)

minor comment, see inline.

http://gerrit.ovirt.org/#/c/27943/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java:

Line 38:             if (!memoryChecker.evaluate(vds, vm)) {
Line 39:                 log.debugFormat("host '{0}' has insufficient memory to 
run the VM", vds.getName());
Line 40:                 
messages.add(VdcBllMessages.ACTION_TYPE_FAILED_VDS_VM_MEMORY.toString());
Line 41:                 AuditLogableBase log = new AuditLogableBase();
Line 42:                 log.addCustomValue("VdsName", vds.getName());
if we have # hosts with no memory, we'll get # messages.
Line 43:                 log.addCustomValue("VmName", vm.getName());
Line 44:                 log.setVdsId(vds.getId());
Line 45:                 log.setVmId(vm.getId());
Line 46:                 AuditLogDirector.log(log, 
AuditLogType.VDS_INSUFFICIENT_MEMORY_TO_RUN_VM);


-- 
To view, visit http://gerrit.ovirt.org/27943
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32b3fa9d24a24042a62ce464642b74118f0ff61e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to