Vered Volansky has uploaded a new change for review. Change subject: webadmin: Fix potential NPE when in CheckboxColumn ......................................................................
webadmin: Fix potential NPE when in CheckboxColumn getValue(object)) in checkboxColumn.render() might return null, resulting in an NPE when used in if. Fix the if to handle null. Note: this bug could only occur if a checkboxColumn is not editable *and* it's value is null. Change-Id: I26f688984083fbd6964972e79e50960b254c547b Signed-off-by: Vered Volansky <[email protected]> Bug-Url: https://bugzilla.redhat.com/1097754 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/27957/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java index 6753bc6..895d12f 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java @@ -90,7 +90,7 @@ if (!canEdit(object)) { sb.append(multipleSelectionAllowed ? INPUT_CHECKBOX_DISABLED_PREFIX : INPUT_RADIO_DISABLED_PREFIX); - if (getValue(object)) { + if (Boolean.TRUE.equals(getValue(object))) { sb.append(CHECKED_ATTR); } String disabledMessage = getDisabledMessage(object); -- To view, visit http://gerrit.ovirt.org/27957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I26f688984083fbd6964972e79e50960b254c547b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
