Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Repair disallow RO in UI ......................................................................
webadmin: Repair disallow RO in UI Qemu currently does not support direct-LUN disks connected using VirtIO-SCSI. This patch blocks this option from UI when adding/editing/attaching a direct-LUN disk with VirtIO-SCSI interface to a VM. This wasn't checked in Add/Edit Disk to Vm dialog, nor in Attach table. IDE behaviour was changed to comply with this behaviour in this patch as well. This patch also removes un-needed verfication for IDE disk. Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90 Bug-Url: https://bugzilla.redhat.com/1097754 Signed-off-by: Vered Volansky <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 21 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
