Omer Frenkel has posted comments on this change. Change subject: core: VdsManger - rename fields to fit convention ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/27378/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 396: vds = DbFacade.getInstance().getVdsDao().get(getVdsId()); Line 397: } Line 398: if (vds.getPreviousStatus() != vds.getStatus()) { Line 399: vds.setPreviousStatus(vds.getStatus()); Line 400: if (vds != null) { should be this.vds Line 401: vds.setPreviousStatus(vds.getStatus()); Line 402: if (vds.getStatus() == VDSStatus.PreparingForMaintenance) { Line 403: calculateNextMaintenanceAttemptTime(); Line 404: } Line 397: } Line 398: if (vds.getPreviousStatus() != vds.getStatus()) { Line 399: vds.setPreviousStatus(vds.getStatus()); Line 400: if (vds != null) { Line 401: vds.setPreviousStatus(vds.getStatus()); should be this.vds.set.. Line 402: if (vds.getStatus() == VDSStatus.PreparingForMaintenance) { Line 403: calculateNextMaintenanceAttemptTime(); Line 404: } Line 405: } Line 398: if (vds.getPreviousStatus() != vds.getStatus()) { Line 399: vds.setPreviousStatus(vds.getStatus()); Line 400: if (vds != null) { Line 401: vds.setPreviousStatus(vds.getStatus()); Line 402: if (vds.getStatus() == VDSStatus.PreparingForMaintenance) { should be this.vds Line 403: calculateNextMaintenanceAttemptTime(); Line 404: } Line 405: } Line 406: } -- To view, visit http://gerrit.ovirt.org/27378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90e26c1a2db4d51f5bd13cf39a59593579fa7648 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
