Yevgeny Zaspitsky has posted comments on this change. Change subject: core: UpdateVmDiskCommandTest asserts ......................................................................
Patch Set 3: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/27765/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-05-16 17:47:04 +0300 Line 6: Line 7: core: UpdateVmDiskCommandTest asserts Line 8: Line 9: Replace the wrong use of assert with JUnit's proper assertNotSame. IMHO the assert usage is proper. See my comment on UpdateVmDiskCommandTest. Line 10: Line 11: Change-Id: I6ca45b8c21c60577e2d70656fecad0ca6c31ead7 http://gerrit.ovirt.org/#/c/27765/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java: Line 343 Line 344 Line 345 Line 346 Line 347 Here the assert is about validate the test itself rather than checking the under the test subject, IMHO assert was used properly. In case of both of the disk interfaces are same should be indicated as an error in the test rather than failure if the under the test class. Line 386 Line 387 Line 388 Line 389 Line 390 same -- To view, visit http://gerrit.ovirt.org/27765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca45b8c21c60577e2d70656fecad0ca6c31ead7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
