Yevgeny Zaspitsky has posted comments on this change. Change subject: core: GetHostListFromExternalProvider generics ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27764/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java: Line 18: private final VDS host1 = new VDS(); Line 19: private final VDS host2 = new VDS(); Line 20: private final VDS existingHost1 = new VDS(); Line 21: private final VDS existingHost2 = new VDS(); Line 22: private final Provider<?> hostProvider = new Provider(); > Adding <?> doesn't add any type safety. "Provider is a raw type. References to generic type Provider<P> should be parameterized" Fixing the production code first will allow eliminating that. Line 23: Line 24: @Before Line 25: @Override Line 26: public void setUp() throws Exception { -- To view, visit http://gerrit.ovirt.org/27764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfeaa553768b7a00437bfcda81e2e6c226bcc59d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
